[libcxx-commits] [PATCH] D95848: Add `noexcept` to `string::find` and similar members.

Zoe Carver via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Feb 2 15:16:28 PST 2021


zoecarver added inline comments.


================
Comment at: libcxx/include/string:1383
         >
-        compare(const _Tp &__t) const;
+        compare(const _Tp &__t) const _NOEXCEPT;
 
----------------
curdeius wrote:
> It seems that you haven't tested this change.
> Should be somewhere here: https://github.com/llvm/llvm-project/tree/main/libcxx/test/std/strings/basic.string/string.ops/string_compare.
Good catch, thanks. Updated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95848/new/

https://reviews.llvm.org/D95848



More information about the libcxx-commits mailing list