[libcxx-commits] [PATCH] D95875: [SystemZ][ZOS] Prefer -nostdlib++ as opposed to -nodefaultlibs when building c++ libraries

[Zibi Sarbino via Phabricator via libcxx-commits]

zibi marked an inline comment as done.
zibi added inline comments.


================
Comment at: libunwind/cmake/config-ix.cmake:34
+  if (LIBUNWIND_SUPPORTS_NODEFAULTLIBS_FLAG)
+    set(CMAKE_REQUIRED_FLAGS "${CMAKE_REQUIRED_FLAGS} -nodefaultlibs")
+  endif()
----------------
mstorsjo wrote:
> Doesn't this end up adding `-nodefaultlibs` twice to `CMAKE_REQUIRED_FLAGS` (the second time below on line 39)?
> Doesn't this end up adding `-nodefaultlibs` twice to `CMAKE_REQUIRED_FLAGS` (the second time below on line 39)?

Thank you for caching this. Line 39 should be deleted but let me wait first for CI to see if the original regression is gone.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95875/new/

https://reviews.llvm.org/D95875