[libcxx-commits] [PATCH] D93971: Add freestanding parameter to libcxx lit

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Feb 2 12:53:14 PST 2021

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

I like this much better! I guess a follow-up would be to rename some of these `libcpp-has-no-xyz` features to just `has-no-xyz` to divorce them from libc++ and make it clear that they are features of the test suite itself, too.

I'm going to be nit-picky and ask that we add a CI job for testing that configuration. This is easily done with the new buildkite setup. You can follow what I did for example in

  commit e0d01294bc124211a8ffb55e69162eb34a242680
  Author: Louis Dionne <ldionne at apple.com>
  Date:   Thu Oct 15 10:32:09 2020 -0400
      [libc++] Allow building libc++ on platforms without a random device
      Some platforms, like several embedded platforms, do not provide a source
      of randomness through a random device. This commit makes it possible to
      build and test libc++ for such platforms, i.e. without std::random_device.
      Surprisingly, the only functionality that doesn't work on such platforms
      is std::random_device itself -- everything else in <random> still works,
      one just has to find alternative ways to seed the PRNGs.



More information about the libcxx-commits mailing list