[libcxx-commits] [PATCH] D93414: [libc++] Adds a make_string test helper function.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked an inline comment as done.
Mordante added inline comments.


================
Comment at: libcxx/test/support/make_string.h:25
+// facilities.
+_LIBCPP_SUPPRESS_DEPRECATED_PUSH
+// Helper function to convert a const char* string to a basic_string<CharT>.
----------------
Mordante wrote:
> ldionne wrote:
> > That is not going to work when the test suite is run against non-libc++. Can we replace by something that doesn't depend on libc++?
> I had a look and `test/std/depr/depr.c.headers/stdio_h.pass.cpp` uses
> ```
> #if defined(__GNUC__) || defined(__clang__)
> #pragma GCC diagnostic ignored "-Wformat-zero-length"
> #pragma GCC diagnostic ignored "-Wdeprecated-declarations" // for tmpnam
> #endif
> ```
> 
> But I'll first have a look at `MultiStringType`. If that suits my needs this revision seems obsolete.
> That is not going to work when the test suite is run against non-libc++. Can we replace by something that doesn't depend on libc++?
With the changed implementation this code is entirely removed.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93414/new/

https://reviews.llvm.org/D93414