[libcxx-commits] [PATCH] D95821: [docs] Explain noexcept policy for narrow contracts.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Can you also update the ReleaseNotes with this change in behaviour?



================
Comment at: libcxx/docs/UsingLibcxx.rst:356
+As of version 14 libc++ will mark functions that do not throw (i.e.,
+"Throws: nothing" as ``noexcept``). This means that functions will not
+report precondition violations by throwing and user-provided functions,
----------------
A bit pedantic, but it seems the Standard capitalizes Nothing.


================
Comment at: libcxx/docs/UsingLibcxx.rst:357
+"Throws: nothing" as ``noexcept``). This means that functions will not
+report precondition violations by throwing and user-provided functions,
+such as custom predicates or custom traits, which throw will not be
----------------
This sentence is quite long. Maybe add a full stop `throwing and user-provided` -> `throwing. User-provided`


================
Comment at: libcxx/docs/UsingLibcxx.rst:361
+
+Before version 14, libc++ did not specify whether a function that did not
+throw would be marked as ``noexcept``, so users should not rely on any
----------------
When adjusting 14 to 13, also change it here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95821/new/

https://reviews.llvm.org/D95821