[libcxx-commits] [PATCH] D95875: [SystemZ][ZOS] Prefer -nostdlib++ as opposed to -nodefaultlibs when building c++ libraries

Zibi Sarbino via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Feb 2 10:42:26 PST 2021


zibi updated this revision to Diff 320849.
zibi marked an inline comment as done.
zibi edited the summary of this revision.
zibi added a comment.
Herald added a subscriber: libcxx-commits.
Herald added 1 blocking reviewer(s): libunwind.

pached created by arc diff


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95875/new/

https://reviews.llvm.org/D95875

Files:
  libcxx/cmake/config-ix.cmake
  libcxxabi/cmake/config-ix.cmake
  libunwind/cmake/config-ix.cmake


Index: libunwind/cmake/config-ix.cmake
===================================================================
--- libunwind/cmake/config-ix.cmake
+++ libunwind/cmake/config-ix.cmake
@@ -17,7 +17,7 @@
 endif()
 
 # The libunwind is using -nostdlib++ at the link step when available,
-# otherwise -nostdlib++ is used. We want all our checks to also
+# otherwise -nodefaultlibs is used. We want all our checks to also
 # use one of these options, otherwise we may end up with an inconsistency between
 # the flags we think we require during configuration (if the checks are
 # performed without one of those options) and the flags that are actually
Index: libcxxabi/cmake/config-ix.cmake
===================================================================
--- libcxxabi/cmake/config-ix.cmake
+++ libcxxabi/cmake/config-ix.cmake
@@ -15,7 +15,7 @@
 endif ()
 
 # The libc++abi is using -nostdlib++ at the link step when available,
-# otherwise -nostdlib++ is used. We want all our checks to also
+# otherwise -nodefaultlibs is used. We want all our checks to also
 # use one of these options, otherwise we may end up with an inconsistency between
 # the flags we think we require during configuration (if the checks are
 # performed without -nodefaultlibs) and the flags that are actually
Index: libcxx/cmake/config-ix.cmake
===================================================================
--- libcxx/cmake/config-ix.cmake
+++ libcxx/cmake/config-ix.cmake
@@ -25,7 +25,7 @@
 endif()
 
 # The libc++ is using -nostdlib++ at the link step when available,
-# otherwise -nostdlib++ is used. We want all our checks to also
+# otherwise -nodefaultlibs is used. We want all our checks to also
 # use one of these options, otherwise we may end up with an inconsistency between
 # the flags we think we require during configuration (if the checks are
 # performed without one of those options) and the flags that are actually


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D95875.320849.patch
Type: text/x-patch
Size: 1912 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210202/b7fef4b9/attachment-0001.bin>


More information about the libcxx-commits mailing list