[libcxx-commits] [PATCH] D93542: [SystemZ][ZOS] Provide CLOCK_MONOTONIC alternative

[Hubert Tong via Phabricator via libcxx-commits]

hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.

LGTM from my end with one comment. Need @ldionne's input.



================
Comment at: libcxx/include/support/ibm/gettod_zos.h:10-11
+
+#ifndef _LIBCPP_SUPPORT_IBM_GETTOD_H
+#define _LIBCPP_SUPPORT_IBM_GETTOD_H
+
----------------
Minor nit: Update header guard to match the filename/path/etc. once that is settled (see comment below).


================
Comment at: libcxx/src/chrono.cpp:14
+#if defined(__MVS__)
+#include <support/ibm/gettod_zos.h> // gettimeofdayMonotonic
+#endif
----------------
Not sure what @ldionne's opinion is here, and sorry for not noticing earlier. There's a `libcxx/src/include/` directory for what I understand to be headers to be used for the library build (as opposed to headers containing interfaces meant to face the library user). I think the header here might fit that first category,


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93542/new/

https://reviews.llvm.org/D93542