[libcxx-commits] [PATCH] D91168: [13/N] [libcxx] Implement the space function for windows

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Feb 2 07:16:04 PST 2021


ldionne added a comment.

> I guess one could try to create a fallback statvfs struct and all that even on windows if that's really needed though, but the ifdeffed code here is pretty selfcontained.

That would be my preferred approach. Can you look into it and see if it can be done? If you remove this bit of windows-specific code from `operations.cpp`, I think this would LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91168/new/

https://reviews.llvm.org/D91168



More information about the libcxx-commits mailing list