[libcxx-commits] [PATCH] D93166: [libc++][format] Add basic_format_parse_context.

Mon Feb 1 13:19:57 PST 2021

mehdi_amini added a comment.

Reverted in 68f66f37d7d7 <https://reviews.llvm.org/rG68f66f37d7d74be7beba56506c4397dadc8538dd> because of the build break mentioned inline, let me know if you need help to reproduce!

================
Comment at: libcxx/include/format:153
+	// behavior when id >= num_args_.
+    if (_VSTD::is_constant_evaluated() && __id >= __num_args_)
+      __throw_format_error("Argument index outside the valid range");
----------------
We have a build breakage on bootstrapping clang here:

```
In file included from /var/lib/buildkite-agent/builds/buildkite-69fdf6c495-wt2bd-1/mlir/mlir-core/libcxx/src/format.cpp:9:
/tmp/ci-nGNyLRM9V3/include/c++/v1/format:153:16: error: no member named 'is_constant_evaluated' in namespace 'std::__1'
    if (_VSTD::is_constant_evaluated() && __id >= __num_args_)
        ~~~~~~~^
1 error generated.
```

See https://buildkite.com/mlir/mlir-core/builds/11261#3cc923a2-b03c-4f8b-a0f1-83d638fff493 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93166/new/

https://reviews.llvm.org/D93166