[libcxx-commits] [PATCH] D116388: [libc++] Properly handle specializations of std::is_placeholder.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone marked 4 inline comments as done.
Quuxplusone added a comment.

> Side note: The preferred way of referring to bugs in the code base should be http://llvm.org/PR51753.

Makes sense. I was unsure whether that would actually redirect to the proper GH issue (notice the GH number is different from the Bugzilla "PR" number), but it turns out that it does, so, cool. :)
I still plan to use `Fixes #51095` in the git commit message, unless you tell me not to.

Anyway, I'm not going to land this until buildkite comes back and is green.



================
Comment at: libcxx/test/std/utilities/function.objects/bind/func.bind/func.bind.isbind/is_placeholder.pass.cpp:22-24
+    static_assert(std::is_placeholder<T&>::value == Expected, "");
+    static_assert(std::is_placeholder<const T>::value == Expected, "");
+    static_assert(std::is_placeholder<const T&>::value == Expected, "");
----------------
ldionne wrote:
> `LIBCPP_STATIC_ASSERT` instead?
> 
> Also, this should have been `_LIBCPP_VERSION` instead -- I guess that's one additional reason to use `LIBCPP_STATIC_ASSERT`.
Yikes, good catch. I was (temporarily?) unaware that `LIBCPP_STATIC_ASSERT` existed; I knew `LIBCPP_ASSERT` but didn't think to look for the other one. Fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116388/new/

https://reviews.llvm.org/D116388