[libcxx-commits] [PATCH] D116388: [libc++] Properly handle specializations of std::is_placeholder.

[Joe Loser via Phabricator via libcxx-commits]

jloser added a comment.

LGTM % a small question.



================
Comment at: libcxx/test/std/utilities/function.objects/bind/func.bind/func.bind.isbind/is_bind_expression.pass.cpp:26
+    static_assert(std::is_bind_expression<const T>::value == Expected, "");
+    static_assert(std::is_bind_expression<const T&>::value == Expected, "");
+#endif
----------------
Since the library code does `__uncvref_t`, should we also test `volatile T` here and below? Or is your thought "down with volatile in the library!" basically? :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116388/new/

https://reviews.llvm.org/D116388