[libcxx-commits] [PATCH] D116344: [libc++] [ABI BREAK] Conform lognormal_distribution::param_type.

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Dec 29 12:06:29 PST 2021


Quuxplusone added inline comments.


================
Comment at: libcxx/include/__random/lognormal_distribution.h:37
+        result_type __m_;
+        result_type __s_;
     public:
----------------
Mordante wrote:
> If I'm correct we go from `3 * sizeof(result_type) + sizeof(bool)` to `2 * sizeof(result_type)`. So it would be possible use an ABI macro. Right?
Yes, it is definitely //possible// to preserve the old code under a macro. The PR summary indicates my opinion on this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116344/new/

https://reviews.llvm.org/D116344



More information about the libcxx-commits mailing list