[libcxx-commits] [PATCH] D116380: [libc++] Use std::addressof in std::function::target

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added a comment.

I don't see the point of having //two// ADL-proofing tests (`robust_against_adl.pass.cpp` and the new one), and I wonder why the old `robust_against_adl.pass.cpp` bothered to test three different cases but you're adding only one new case (like, should there be a matching test for `std::function<int()>` as well as `std::function<void()>`?) but anyway this certainly seems code-correct and sufficiently-tested at this point. :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116380/new/

https://reviews.llvm.org/D116380