[libcxx-commits] [PATCH] D116380: [libc++] Use std::addressof in std::function::target

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Dec 29 09:40:05 PST 2021


Mordante accepted this revision as: Mordante.
Mordante added a comment.

LGTM except for a minor issue.



================
Comment at: libcxx/test/std/utilities/function.objects/func.wrap/func.wrap.func/addressof.pass.cpp:22
+    int operator()() const { return 1; }
+};
+
----------------
Can you use `test/support/operator_hijacker.h`'s `operator_hijacker` instead? If not I would like the `operator&()` to be deleted.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116380/new/

https://reviews.llvm.org/D116380



More information about the libcxx-commits mailing list