[libcxx-commits] [PATCH] D116346: [libc++] Fix bug #52902

Tue Dec 28 16:29:31 PST 2021

Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added a comment.

LGTM!

I recommend that you use a git commit message that includes either `Fixes https://github.com/llvm/llvm-project/issues/52902` or simply `Fixes #52902`, on a line/paragraph by itself.
For an example of the former, see 960712ccc7103ded3d95e10c61516126836a1eba <https://reviews.llvm.org/rG960712ccc7103ded3d95e10c61516126836a1eba>; for an example of the latter, see 6e28b86cc629c351b1f5d238146af1b6f7ceb785 <https://reviews.llvm.org/rG6e28b86cc629c351b1f5d238146af1b6f7ceb785>.
(I myself am going to start doing the latter.)
This will tell GitHub to associate that commit with that GitHub issue, and in fact I believe it will //auto-close// that issue, which is nice.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116346/new/

https://reviews.llvm.org/D116346