[libcxx-commits] [PATCH] D116344: [libc++] [ABI BREAK] Conform lognormal_distribution::param_type.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone created this revision.
Quuxplusone added reviewers: ldionne, howard.hinnant, EricWF, Mordante, libc++.
Quuxplusone added a project: libc++.
Quuxplusone requested review of this revision.
Herald added a subscriber: libcxx-commits.
Herald added 1 blocking reviewer(s): libc++.

Fixes https://github.com/llvm/llvm-project/issues/52906

Unless I'm mistaken, this

- preserves the size and layout of `lognormal_distribution<T>`; but
- shrinks the size of `lognormal_distribution<T>::param_type` (this is the ABI break).

I think this is an acceptably negligible amount of ABI breakage that we don't need to macro it up, but will defer to @ldionne etc.
(I think the bug(s) are severe enough that "just leave it permanently as-is because Hyrum's Law" should //not// be an acceptable outcome.)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D116344

Files:
  libcxx/include/__random/lognormal_distribution.h
  libcxx/test/std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.lognormal/eval_param.PR52906.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D116344.396436.patch
Type: text/x-patch
Size: 6443 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20211228/b75d3481/attachment.bin>