[libcxx-commits] [PATCH] D114733: [libc++] Make __wrap_iter constexpr

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Dec 28 14:44:00 PST 2021


Quuxplusone added inline comments.


================
Comment at: libcxx/include/__iterator/wrap_iter.h:72-76
+        if (this != _VSTD::addressof(__x) && !__libcpp_is_constant_evaluated())
         {
             __get_db()->__iterator_copy(this, _VSTD::addressof(__x));
             __i = __x.__i;
         }
----------------
@philnik: https://github.com/llvm/llvm-project/issues/52902
Could you take a look when you get a chance? (And scan for any other similar bugs that might be hiding elsewhere in here.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114733/new/

https://reviews.llvm.org/D114733



More information about the libcxx-commits mailing list