[libcxx-commits] [PATCH] D116334: [libc++] Remove std::basic_string's base class in ABIv2

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Interesting, I thought this looked somewhat familiar and it's indeed something that I expected to be done in D111173 <https://reviews.llvm.org/D111173>.

I like to hear @ldionne's opinion why it wasn't done in D111173 <https://reviews.llvm.org/D111173>



================
Comment at: libcxx/include/__config:111
+// Remove basic_string common base
+#  define _LIBCPP_ABI_STRING_REMOVE_BASE
 #elif _LIBCPP_ABI_VERSION == 1
----------------
This looks more consistent with the other ABI macros.


================
Comment at: libcxx/include/string:626
     _LIBCPP_NORETURN _LIBCPP_EXPORTED_FROM_ABI void __throw_out_of_range() const;
 };
 
----------------
This should also be guarded by the ABI macro.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116334/new/

https://reviews.llvm.org/D116334