[libcxx-commits] [PATCH] D116295: [libc++] Add missing templated version of `std::lerp`
Arthur O'Dwyer via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Sun Dec 26 20:08:14 PST 2021
Quuxplusone marked an inline comment as done.
Quuxplusone added inline comments.
================
Comment at: libcxx/test/std/numerics/c.math/cmath.pass.cpp:1140
static_assert((std::is_same<decltype(std::hypot((float)0, (int)0, (long double)0)), long double>::value), "");
- static_assert((std::is_same<decltype(std::hypot((float)0, (unsigned int)0)), double>::value), "");
static_assert((std::is_same<decltype(std::hypot((float)0, (double)0, (long)0)), double>::value), "");
----------------
jloser wrote:
> Why remove this? Seems unrelated?
This is a duplicate of old line 1119, erroneously copied down here with the three-argument overload even though it's passing only two arguments. I discovered this error when I copied these lines to use with `lerp` (because `lerp` doesn't have a two-argument overload). I can put this in a separate git commit, for sure.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116295/new/
https://reviews.llvm.org/D116295
More information about the libcxx-commits
mailing list