[libcxx-commits] [PATCH] D116268: [libc++][ranges] Add indirectly_comparable concept

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Dec 26 13:50:28 PST 2021


Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added a comment.

LGTM % comments



================
Comment at: libcxx/include/__iterator/indirectly_comparable.h:22
+template <class _I1, class _I2, class _Rp, class _P1 = identity, class _P2 = identity>
+concept indirectly_comparable = indirect_binary_predicate<_Rp, projected<_I1, _P1>, projected<_I2, _P2>>;
+
----------------



================
Comment at: libcxx/include/__iterator/iter_swap.h:17
 #include <__iterator/iterator_traits.h>
+#include <__iterator/projected.h>
 #include <__iterator/readable_traits.h>
----------------
These two includes can vanish again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116268/new/

https://reviews.llvm.org/D116268



More information about the libcxx-commits mailing list