[libcxx-commits] [PATCH] D116172: [libc++] Add the version header to all headers.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added a comment.

LGTM! It occurs to me that we could add a Python check to enforce this, but that's a question for another day.
Please do add `version` to the "ignored headers" on the graph-header-deps script, though:

  diff --git a/libcxx/utils/graph_header_deps.py b/libcxx/utils/graph_header_deps.py
   
   def is_config_header(h):
  -    return os.path.basename(h) in ['__config', '__libcpp_version', '__undef_macros']
  +    return os.path.basename(h) in ['__config', '__libcpp_version', '__undef_macros', 'version']


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116172/new/

https://reviews.llvm.org/D116172