[libcxx-commits] [PATCH] D116198: [libc++] [test] [NFC] Flatten the directory structure a bit

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Dec 22 17:28:30 PST 2021


Quuxplusone created this revision.
Quuxplusone added reviewers: libc++, Mordante, philnik, var-const, jloser, ldionne.
Quuxplusone added a project: libc++.
Quuxplusone requested review of this revision.
Herald added a subscriber: libcxx-commits.
Herald added 1 blocking reviewer(s): libc++.

These test files for [ranges.access] are all pretty similar, and hiding them in one-file-per-directory doesn't accomplish anything (except perhaps hiding the fact that we don't have very many tests for `cbegin` and `cend`). Pull them all up to the same level, so we can see that they're all present and accounted for.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D116198

Files:
  libcxx/test/std/ranges/range.access/begin.pass.cpp
  libcxx/test/std/ranges/range.access/data.pass.cpp
  libcxx/test/std/ranges/range.access/empty.pass.cpp
  libcxx/test/std/ranges/range.access/end.pass.cpp
  libcxx/test/std/ranges/range.access/range.access.begin/begin.pass.cpp
  libcxx/test/std/ranges/range.access/range.access.cbegin/cbegin.compile.pass.cpp
  libcxx/test/std/ranges/range.access/range.access.cend/cend.compile.pass.cpp
  libcxx/test/std/ranges/range.access/range.access.end/end.pass.cpp
  libcxx/test/std/ranges/range.access/range.prim/data.pass.cpp
  libcxx/test/std/ranges/range.access/range.prim/empty.pass.cpp
  libcxx/test/std/ranges/range.access/range.prim/size.pass.cpp
  libcxx/test/std/ranges/range.access/range.prim/ssize.pass.cpp
  libcxx/test/std/ranges/range.access/size.pass.cpp
  libcxx/test/std/ranges/range.access/ssize.pass.cpp


Index: libcxx/test/std/ranges/range.access/range.access.cend/cend.compile.pass.cpp
===================================================================
--- libcxx/test/std/ranges/range.access/range.access.cend/cend.compile.pass.cpp
+++ /dev/null
@@ -1 +0,0 @@
-// Tested in end.pass.cpp.
Index: libcxx/test/std/ranges/range.access/range.access.cbegin/cbegin.compile.pass.cpp
===================================================================
--- libcxx/test/std/ranges/range.access/range.access.cbegin/cbegin.compile.pass.cpp
+++ /dev/null
@@ -1 +0,0 @@
-// Tested in begin.pass.cpp.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D116198.395952.patch
Type: text/x-patch
Size: 584 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20211223/be4757e8/attachment.bin>


More information about the libcxx-commits mailing list