[libcxx-commits] [PATCH] D116132: [libcxx] [test] Prepare the ctime.timespec test for mingw CI env upgrades

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Dec 22 05:17:48 PST 2021


This revision was automatically updated to reflect the committed changes.
Closed by commit rG516882a8f23b: [libcxx] [test] Prepare the ctime.timespec test for mingw CI env upgrades (authored by mstorsjo).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116132/new/

https://reviews.llvm.org/D116132

Files:
  libcxx/test/std/language.support/support.runtime/ctime.timespec.compile.pass.cpp


Index: libcxx/test/std/language.support/support.runtime/ctime.timespec.compile.pass.cpp
===================================================================
--- libcxx/test/std/language.support/support.runtime/ctime.timespec.compile.pass.cpp
+++ libcxx/test/std/language.support/support.runtime/ctime.timespec.compile.pass.cpp
@@ -15,8 +15,11 @@
 // unavailable until macOS 10.15
 // XFAIL: use_system_cxx_lib && target={{.+}}-apple-macosx10.{{9|10|11|12|13|14}}
 
-// MinGW lacks timespec_get.
-// XFAIL: target={{.+}}-windows-gnu
+// MinGW used to lack timespec_get, but has got it in newer versions.
+// Mark the test as unsupported for a transition period, to avoid spurious
+// failures when upgrading the precommit testing environment. After
+// the testing environment is upgraded, we could remove the marking altogether.
+// UNSUPPORTED: target={{.+}}-windows-gnu
 
 #include <ctime>
 #include <type_traits>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D116132.395847.patch
Type: text/x-patch
Size: 915 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20211222/cc8ff84d/attachment.bin>


More information about the libcxx-commits mailing list