[libcxx-commits] [libcxx] 516882a - [libcxx] [test] Prepare the ctime.timespec test for mingw CI env upgrades

[Martin Storsjö via libcxx-commits]

Author: Martin Storsjö
Date: 2021-12-22T15:14:55+02:00
New Revision: 516882a8f23b36c925ad8be89846bfa36915ce73

URL: https://github.com/llvm/llvm-project/commit/516882a8f23b36c925ad8be89846bfa36915ce73
DIFF: https://github.com/llvm/llvm-project/commit/516882a8f23b36c925ad8be89846bfa36915ce73.diff

LOG: [libcxx] [test] Prepare the ctime.timespec test for mingw CI env upgrades

The test is currently marked XFAIL for mingw environments, but latest
mingw-w64 got support for timespec_get:
https://github.com/mingw-w64/mingw-w64/commit/e62a0a987c80f6a6fdac3e350943ae8085de0bd5

The CI environment will probably be upgraded to a state where this
test is passing only after 14.x is branched in the llvm-project monorepo.

If we'd just go from having an XFAIL to no marking at all (when CI is
passing), we'd have to update both main and 14.x branches in sync
exactly when the CI runners are updated to a newer version.

Instead, mark the test as temporarily unsupported (so it doesn't
cause failed builds when the CI environment is updated); after the
CI environments are upgraded to such a state, we can remove the
UNSUPPORTED marking to start requiring it to pass on the main branch,
without needing to synchronize that change to anything else.

Differential Revision: https://reviews.llvm.org/D116132

Added: 
    

Modified: 
    libcxx/test/std/language.support/support.runtime/ctime.timespec.compile.pass.cpp

Removed: 
    


################################################################################
diff  --git a/libcxx/test/std/language.support/support.runtime/ctime.timespec.compile.pass.cpp b/libcxx/test/std/language.support/support.runtime/ctime.timespec.compile.pass.cpp
index d0d06c477c980..b906ad928536a 100644
--- a/libcxx/test/std/language.support/support.runtime/ctime.timespec.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.runtime/ctime.timespec.compile.pass.cpp
@@ -15,8 +15,11 @@
 // unavailable until macOS 10.15
 // XFAIL: use_system_cxx_lib && target={{.+}}-apple-macosx10.{{9|10|11|12|13|14}}
 
-// MinGW lacks timespec_get.
-// XFAIL: target={{.+}}-windows-gnu
+// MinGW used to lack timespec_get, but has got it in newer versions.
+// Mark the test as unsupported for a transition period, to avoid spurious
+// failures when upgrading the precommit testing environment. After
+// the testing environment is upgraded, we could remove the marking altogether.
+// UNSUPPORTED: target={{.+}}-windows-gnu
 
 #include <ctime>
 #include <type_traits>