[libcxx-commits] [PATCH] D115838: [libc++] [ranges] Remove the static_assert from ranges::begin and ranges::end.

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Dec 21 19:24:09 PST 2021


Quuxplusone updated this revision to Diff 395786.
Quuxplusone added a comment.

...And remove the new test cases for `ranges::begin(static_cast<int(&)[]>(a))` and so on, again. These casts are new in C++20, so they're also new in Clang 14: Clang 12 and 13 fail the new test. So, remove them so I can land this, and then we can make a new test file for these few cases after that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115838/new/

https://reviews.llvm.org/D115838

Files:
  libcxx/include/__ranges/access.h
  libcxx/test/libcxx/ranges/range.access/begin.incomplete_type.sh.cpp
  libcxx/test/libcxx/ranges/range.access/end.incomplete_type.pass.cpp
  libcxx/test/libcxx/ranges/range.access/range.access.begin/incomplete.verify.cpp
  libcxx/test/libcxx/ranges/range.access/range.access.cbegin/incomplete.verify.cpp
  libcxx/test/libcxx/ranges/range.access/range.access.cend/incomplete.verify.cpp
  libcxx/test/libcxx/ranges/range.access/range.access.end/incomplete.verify.cpp
  libcxx/test/libcxx/ranges/range.access/range.prim/data.incomplete.verify.cpp
  libcxx/test/libcxx/ranges/range.access/range.prim/empty.incomplete.verify.cpp
  libcxx/test/std/ranges/range.access/range.access.begin/begin.pass.cpp
  libcxx/test/std/ranges/range.access/range.access.end/end.pass.cpp
  libcxx/test/std/ranges/range.access/range.prim/empty.pass.cpp
  libcxx/test/std/ranges/range.access/range.prim/size.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D115838.395786.patch
Type: text/x-patch
Size: 22017 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20211222/82ca09ea/attachment-0001.bin>


More information about the libcxx-commits mailing list