[libcxx-commits] [PATCH] D116132: [libcxx] [test] Prepare the ctime.timespec test for mingw CI env upgrades

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo created this revision.
mstorsjo added a reviewer: ldionne.
mstorsjo requested review of this revision.
Herald added a project: libc++.
Herald added a reviewer: libc++.

The test is currently marked XFAIL for mingw environments, but in
the future, it will start passing. (I'll update this with a reference
to the mingw-w64 commit once I've pushed it.)

The CI environment will probably be upgraded to a state where it is
passing only after 14.x is branched in the llvm-project monorepo.

If we'd just go from having an XFAIL to no marking at all (when CI is
passing), we'd have to update both main and 14.x branches in sync
exactly when the CI runners are updated to a newer version.

Instead, mark the test as temporarily unsupported (so it doesn't
cause failed builds when the CI environment is updated); after the
CI environments are upgraded to such a state, we can remove the
UNSUPPORTED marking to start requiring it to pass on the main branch,
without needing to synchronize that change to anything else.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D116132

Files:
  libcxx/test/std/language.support/support.runtime/ctime.timespec.compile.pass.cpp


Index: libcxx/test/std/language.support/support.runtime/ctime.timespec.compile.pass.cpp
===================================================================
--- libcxx/test/std/language.support/support.runtime/ctime.timespec.compile.pass.cpp
+++ libcxx/test/std/language.support/support.runtime/ctime.timespec.compile.pass.cpp
@@ -15,8 +15,11 @@
 // unavailable until macOS 10.15
 // XFAIL: use_system_cxx_lib && target={{.+}}-apple-macosx10.{{9|10|11|12|13|14}}
 
-// MinGW lacks timespec_get.
-// XFAIL: target={{.+}}-windows-gnu
+// MinGW used to lack timespec_get, but has got it in newer versions.
+// Mark the test as unsupported for a transition period, to avoid spurious
+// failures when upgrading the precommit testing environment. After
+// the testing environment is upgraded, we could remove the marking altogether.
+// UNSUPPORTED: target={{.+}}-windows-gnu
 
 #include <ctime>
 #include <type_traits>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D116132.395757.patch
Type: text/x-patch
Size: 915 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20211221/d5c9221e/attachment.bin>