[libcxx-commits] [PATCH] D111202: [libc++] Add from-scratch testing configs for Windows

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Dec 21 14:54:06 PST 2021


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

Regarding naming, we already have `llvm-libc++-shared-gcc.cfg.in`, so please either update that one in a separate patch too, or keep the compiler last for consistency. Either way works for me.

Thanks a lot for splitting off the other changes, I think we've managed to improve the infrastructure while adding support for this platform, which is the way it should be done. Thanks for your work on this.

LGTM if CI is green -- I don't think I need to see this even if further changes are required, so don't be blocked on me being absent during the holidays in case you need to make more changes to make this pass.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111202/new/

https://reviews.llvm.org/D111202



More information about the libcxx-commits mailing list