[libcxx-commits] [PATCH] D116078: [libc++][ranges] Implement `construct_at` and `destroy{, _at}`.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/include/__memory/ranges_construct_at.h:42
+
+  constexpr explicit __fn(__tag __x) noexcept : __function_like(__x) {}
+
----------------
I miss a lot of `_LIBCPP_HIDE_FROM_ABI` annotations.


================
Comment at: libcxx/test/std/utilities/memory/specialized.algorithms/specialized.destroy/ranges_destroy.pass.cpp:218
+  // TODO: Until std::construct_at has support for arrays, it's impossible to test this
+  //       in a constexpr context.
+  // static_assert(test_arrays());
----------------
Please add a link to D114903, which implements the missing feature.


================
Comment at: libcxx/test/std/utilities/memory/specialized.algorithms/specialized.destroy/ranges_destroy_at.pass.cpp:154
+  // TODO: Until std::construct_at has support for arrays, it's impossible to test this
+  //       in a constexpr context.
+  // static_assert(test_arrays());
----------------
Please add a link to D114903, which implements the missing feature.


================
Comment at: libcxx/test/std/utilities/memory/specialized.algorithms/specialized.destroy/ranges_destroy_n.pass.cpp:140
+  // TODO: Until std::construct_at has support for arrays, it's impossible to test this
+  //       in a constexpr context.
+  // static_assert(test_arrays());
----------------
Please add a link to D114903, which implements the missing feature.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116078/new/

https://reviews.llvm.org/D116078