[libcxx-commits] [PATCH] D116010: [libcxx] [test] Don't rerun supportsVerify for each individual test

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

Extra conclusion (I'll amend it to the commit message):

By reimplementing this based on `hasCompileFlag()`, it also implicitly fixes two other issues: Previously, `_supportsVerify` called `subprocess.call()` directly, which can interpret command line quoting differently than `lit.TestRunner`.

(In particular, TestRunner handles arguments quoted by a single quote, while launching Windows processes with subprocess.call() only supports double quotes. This allows using `shlex.quote()`, which uses single quotes, everywhere - as all commands now go through TestRunner.)

Secondly, the old `_supportsVerify` method didn't include either `%{flags)` or `%{compile_flags}`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116010/new/

https://reviews.llvm.org/D116010