[libcxx-commits] [PATCH] D116010: [libcxx] [test] Don't rerun supportsVerify for each individual test

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo marked an inline comment as done.
mstorsjo added inline comments.


================
Comment at: libcxx/utils/libcxx/test/dsl.py:180-185
+    command = "%{{cxx}} -xc++ {} -Werror -fsyntax-only -Xclang -verify-ignore-unexpected".format(os.devnull)
+    command = lit.TestRunner.applySubstitutions([command], config.substitutions,
+                                                recursion_limit=config.recursiveExpansionLimit)[0]
+    devNull = open(os.devnull, 'w')
+    result = subprocess.call(command, shell=True, stdout=devNull, stderr=devNull)
+    return result == 0
----------------
ldionne wrote:
> If we move it here, I suggest we rewrite it as:
> 
> ```
> return hasCompileFlag(config, '-Xclang -verify-ignore-unexpected')
> ```
Ok, will try. That actually would fix two other issues I was planning on fixing afterwards.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116010/new/

https://reviews.llvm.org/D116010