[libcxx-commits] [PATCH] D114001: [libc++][format] Adds formatter floating-point.

[Asher Mancinelli via Phabricator via libcxx-commits]

ashermancinelli added inline comments.


================
Comment at: libcxx/include/__format/formatter_floating_point.h:50
+// If the compiler has no concepts support, the format header will be disabled.
+// Without concepts support enable_if needs to be used and that too much effort
+// to support compilers with partial C++20 support.
----------------



================
Comment at: libcxx/include/__format/formatter_floating_point.h:541
+    // Therefore the value is processed as a positive value.
+    // The function @ref __insert_sign will a '-' when the value was negative.
+
----------------



================
Comment at: libcxx/include/__format/formatter_floating_point.h:564
+      // - An exponent needs to move one position to the right.
+      // So it's save to increment the value unconditionally.
+      ++__result.__exponent;
----------------



================
Comment at: libcxx/include/__format/formatter_floating_point.h:644
+  ///
+  /// This means the caller never has convert the contents of the buffer to
+  /// upper case or search for radix points and the location of the exponent.
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114001/new/

https://reviews.llvm.org/D114001