[libcxx-commits] [PATCH] D115989: [libc++][format] Disable default formatter.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked 4 inline comments as done.
Mordante added inline comments.


================
Comment at: libcxx/test/std/utilities/format/format.formatter/format.formatter.spec/types.compile.pass.cpp:268
+  assert_formatter_is_disabled<std::optional<int>, CharT>();
+  assert_formatter_is_disabled<std::variant<int>, CharT>();
+}
----------------
vitaut wrote:
> Quuxplusone wrote:
> > ```
> > assert_formatter_is_disabled<const int*, CharT>();
> > assert_formatter_is_disabled<c, CharT>();
> > assert_formatter_is_disabled<c*, CharT>();
> > assert_formatter_is_disabled<const c*, CharT>();
> > assert_formatter_is_disabled<const char*, wchar_t>();
> > assert_formatter_is_disabled<const char*, char8_t>();  // ?
> > ```
> Maybe also test `volatile int*` for completeness?
I added these tests and some more. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115989/new/

https://reviews.llvm.org/D115989