[libcxx-commits] [PATCH] D115999: [libc++][format] Finish P0645 Text Formatting.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D115999#3201842 <https://reviews.llvm.org/D115999#3201842>, @vitaut wrote:

>> All parts of the paper have been implemented
>
> Is the floating-point formatting fully implemented? It relies on `to_chars` or equivalent functionality to be available.

It's fully implemented in D114001 <https://reviews.llvm.org/D114001> using `to_chars`. The `to_chars` implementation has been provided by Microsoft and has one minor caveat; it casts a `long double` to a `double` so it doesn't format correctly. (On Windows both types have the same underlying type, so it works fine for Microsoft.) But I consider that an issue in `to_chars` and not in `<format>`. Improving `to_chars`'s `long double` support is on my todo list.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115999/new/

https://reviews.llvm.org/D115999