[libcxx-commits] [libcxx] f195fd9 - [libc++][ranges][NFC] Remove extraneous cleanup checks.

Konstantin Varlamov via libcxx-commits libcxx-commits at lists.llvm.org
Thu Dec 16 14:48:06 PST 2021


Author: Konstantin Varlamov
Date: 2021-12-16T14:47:59-08:00
New Revision: f195fd915ebdd5a0015ae019471dbef47743b1c0

URL: https://github.com/llvm/llvm-project/commit/f195fd915ebdd5a0015ae019471dbef47743b1c0
DIFF: https://github.com/llvm/llvm-project/commit/f195fd915ebdd5a0015ae019471dbef47743b1c0.diff

LOG: [libc++][ranges][NFC] Remove extraneous cleanup checks.

There is no need to check the counters on `Counted` after destroying
elements in the range because these tests are not testing `destroy`.

Differential Revision: https://reviews.llvm.org/D115839

Added: 
    

Modified: 
    libcxx/test/std/utilities/memory/specialized.algorithms/uninitialized.construct.default/ranges_uninitialized_default_construct.pass.cpp
    libcxx/test/std/utilities/memory/specialized.algorithms/uninitialized.construct.default/ranges_uninitialized_default_construct_n.pass.cpp

Removed: 
    


################################################################################
diff  --git a/libcxx/test/std/utilities/memory/specialized.algorithms/uninitialized.construct.default/ranges_uninitialized_default_construct.pass.cpp b/libcxx/test/std/utilities/memory/specialized.algorithms/uninitialized.construct.default/ranges_uninitialized_default_construct.pass.cpp
index 549b18ff33e6d..8552850fa3d67 100644
--- a/libcxx/test/std/utilities/memory/specialized.algorithms/uninitialized.construct.default/ranges_uninitialized_default_construct.pass.cpp
+++ b/libcxx/test/std/utilities/memory/specialized.algorithms/uninitialized.construct.default/ranges_uninitialized_default_construct.pass.cpp
@@ -109,8 +109,6 @@ int main(int, char**) {
     assert(Counted::total_objects == N);
 
     std::destroy(buf.begin(), buf.end());
-    assert(Counted::current_objects == 0);
-    assert(Counted::total_objects == N);
     Counted::reset();
   }
 
@@ -125,8 +123,6 @@ int main(int, char**) {
     assert(Counted::total_objects == N);
 
     std::destroy(buf.begin(), buf.end());
-    assert(Counted::current_objects == 0);
-    assert(Counted::total_objects == N);
     Counted::reset();
   }
 

diff  --git a/libcxx/test/std/utilities/memory/specialized.algorithms/uninitialized.construct.default/ranges_uninitialized_default_construct_n.pass.cpp b/libcxx/test/std/utilities/memory/specialized.algorithms/uninitialized.construct.default/ranges_uninitialized_default_construct_n.pass.cpp
index ff2660d886845..742b16e9cc030 100644
--- a/libcxx/test/std/utilities/memory/specialized.algorithms/uninitialized.construct.default/ranges_uninitialized_default_construct_n.pass.cpp
+++ b/libcxx/test/std/utilities/memory/specialized.algorithms/uninitialized.construct.default/ranges_uninitialized_default_construct_n.pass.cpp
@@ -90,8 +90,6 @@ int main(int, char**) {
     assert(Counted::total_objects == N);
 
     std::destroy(buf.begin(), buf.end());
-    assert(Counted::current_objects == 0);
-    assert(Counted::total_objects == N);
     Counted::reset();
   }
 


        


More information about the libcxx-commits mailing list