[libcxx-commits] [PATCH] D115578: [libc++][NFC] Granularize <filesystem>

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.

This LGTM but we have to figure out why CI is failing. Thanks for modularizing this!



================
Comment at: libcxx/include/__filesystem/file_type.h:20
+
+_LIBCPP_AVAILABILITY_FILESYSTEM_PUSH
+
----------------
I think the Apple back-deployment CI is failing because this `_LIBCPP_AVAILABILITY_FILESYSTEM_PUSH`/_LIBCPP_AVAILABILITY_FILESYSTEM_POP` pair is a no-op (it doesn't apply the attribute to any declaration in-between, because there's only an enum in-between). Removing this pair should fix the CI, and I think that's correct because we don't want to mark that enum as unavailable (well I guess we don't care whether it is marked or not, since it has no dependency on the dylib content).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115578/new/

https://reviews.llvm.org/D115578