[libcxx-commits] [PATCH] D115839: [libc++][ranges][NFC] Remove extraneous cleanup checks.

[Konstantin Varlamov via Phabricator via libcxx-commits]

var-const created this revision.
var-const requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

There is no need to check the counters on `Counted` after destroying
elements in the range because these tests are not testing `destroy`.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D115839

Files:
  libcxx/test/std/utilities/memory/specialized.algorithms/uninitialized.construct.default/ranges_uninitialized_default_construct.pass.cpp
  libcxx/test/std/utilities/memory/specialized.algorithms/uninitialized.construct.default/ranges_uninitialized_default_construct_n.pass.cpp


Index: libcxx/test/std/utilities/memory/specialized.algorithms/uninitialized.construct.default/ranges_uninitialized_default_construct_n.pass.cpp
===================================================================
--- libcxx/test/std/utilities/memory/specialized.algorithms/uninitialized.construct.default/ranges_uninitialized_default_construct_n.pass.cpp
+++ libcxx/test/std/utilities/memory/specialized.algorithms/uninitialized.construct.default/ranges_uninitialized_default_construct_n.pass.cpp
@@ -90,8 +90,6 @@
     assert(Counted::total_objects == N);
 
     std::destroy(buf.begin(), buf.end());
-    assert(Counted::current_objects == 0);
-    assert(Counted::total_objects == N);
     Counted::reset();
   }
 
Index: libcxx/test/std/utilities/memory/specialized.algorithms/uninitialized.construct.default/ranges_uninitialized_default_construct.pass.cpp
===================================================================
--- libcxx/test/std/utilities/memory/specialized.algorithms/uninitialized.construct.default/ranges_uninitialized_default_construct.pass.cpp
+++ libcxx/test/std/utilities/memory/specialized.algorithms/uninitialized.construct.default/ranges_uninitialized_default_construct.pass.cpp
@@ -109,8 +109,6 @@
     assert(Counted::total_objects == N);
 
     std::destroy(buf.begin(), buf.end());
-    assert(Counted::current_objects == 0);
-    assert(Counted::total_objects == N);
     Counted::reset();
   }
 
@@ -125,8 +123,6 @@
     assert(Counted::total_objects == N);
 
     std::destroy(buf.begin(), buf.end());
-    assert(Counted::current_objects == 0);
-    assert(Counted::total_objects == N);
     Counted::reset();
   }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D115839.394724.patch
Type: text/x-patch
Size: 1655 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20211216/758a9432/attachment.bin>