[libcxx-commits] [PATCH] D115588: [libcxx][test] Verify customization point object properties

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Dec 15 17:05:24 PST 2021


Quuxplusone added a comment.

Mainly I'm ambivalent:

> I have no particular opinion on whether these tests should be separated [...] or massed together [...E]ither way might make it harder //or// easier to forget to do that, depending on your personal git-grepping style.

But, another advantage of the massed-together approach is that we can go ahead and add commented-out lines for all the unimplemented CPOs (as @jloser has done). This gives a "TODO" list that is more explicit rather than implicit. Which is good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115588/new/

https://reviews.llvm.org/D115588



More information about the libcxx-commits mailing list