[libcxx-commits] [PATCH] D115795: [libc++] Add GCC workaround in std::char_traits<char>::length()

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision.
Quuxplusone added a comment.
This revision is now accepted and ready to land.

I'm still surprised that there's only //one// test affected by this; but my `git grep`-fu was unable to turn up any others.

Btw, this is a great illustration of the mantra "If you aren't testing it, it doesn't work". With your original PR, with zero `libcxx/test/` diffs, you didn't find that single dumb typo. (Not a knock on your abilities — everyone makes such typos!) With one touch of `libcxx/test/`, ta-da, buildkite detected the typo for you. :) We should always make sure that when we change code, we're changing a codepath that is actually tested in the test suite — if it's not tested, dollars to donuts it doesn't work.

Ship it!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115795/new/

https://reviews.llvm.org/D115795