[libcxx-commits] [PATCH] D115588: [libcxx][test] Verify customization point object properties

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Dec 15 14:28:03 PST 2021


ldionne added a comment.

Personally I quite liked the approach where we'd have a helper to check that a function object is a CPO and then we'd check it from each individual CPO test, but this is fine too. IMO this is just a bit easier to forget to update.



================
Comment at: libcxx/test/std/library/description/conventions/customization.point.object/cpo.pass.cpp:41
+
+int main(int, char**)
+{
----------------
This `main()` can be removed, and the test can be made a `.compile.pass.cpp` test instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115588/new/

https://reviews.llvm.org/D115588



More information about the libcxx-commits mailing list