[libcxx-commits] [PATCH] D115795: [libc++] Add GCC workaround in std::char_traits<char>::length()

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone requested changes to this revision.
Quuxplusone added a comment.
This revision now requires changes to proceed.

The code itself looks reasonable, but I would expect to see some related changes in `libcxx/test/`.
Surely this allows us to eliminate one or more `UNSUPPORTED: gcc-11` somewhere in the test suite.
Maybe even eliminate `constexpr_char_traits.h` altogether?! (But probably not.)

Also, looks like you're missing a level of indentation on lines 343–348.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115795/new/

https://reviews.llvm.org/D115795