[libcxx-commits] [PATCH] D115656: [libc++] Fix wrongly non-inline basic_string::shrink_to_fit

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/include/string:3322
 template <class _CharT, class _Traits, class _Allocator>
 void
 basic_string<_CharT, _Traits, _Allocator>::reserve(size_type __requested_capacity)
----------------
Just curious but there are more similar functions not marked as `inline`. Are they also an issue and should they be fixed?
It would be odd if all these functions are "broken".

I wonder whether this is really the proper fix. Looking at `include/__string` it contains
`_Func(_LIBCPP_FUNC_VIS void basic_string<_CharType>::reserve(size_type)) \`
But no entry for `shrink_to_fit`.
Does adding `shrink_to_fit` to that list solve the issue.

(I didn't look for more omissions in `include/__string`.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115656/new/

https://reviews.llvm.org/D115656