[libcxx-commits] [PATCH] D115312: [libc++] [ranges] Simplify and fix a bug in ranges::empty.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone updated this revision to Diff 393786.
Quuxplusone added a comment.

Review comments.
Update with my proposed new-and-improved way of getting reasonable diagnostics when the SFINAE fails.

Guess what? We had a test/libcxx/ test that was supposed to test these diagnostics, but it was testing `ranges::begin` instead of `ranges::empty`.

New-and-improved CPO design coming to all the other ranges.access CPOs, in a PR depending on this one that I'll upload shortly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115312/new/

https://reviews.llvm.org/D115312

Files:
  libcxx/include/__ranges/empty.h
  libcxx/test/libcxx/ranges/range.access/empty.verify.cpp
  libcxx/test/libcxx/ranges/range.access/range.prim/empty.incomplete.verify.cpp
  libcxx/test/std/ranges/range.access/range.prim/empty.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D115312.393786.patch
Type: text/x-patch
Size: 9461 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20211213/9a1bfc12/attachment.bin>