[libcxx-commits] [PATCH] D115598: [libc++][NFC] Remove goto from std::string

Nilay Vaish via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Dec 12 12:11:31 PST 2021


nilayvaish requested changes to this revision.
nilayvaish added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/include/string:1697
 
+    basic_string& __null_terminate_at(pointer __p, size_type __newsz) {
+      __set_size(__newsz);
----------------
The first param should be value_type* and update places where pointer is being to passed to pass value_type*.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115598/new/

https://reviews.llvm.org/D115598



More information about the libcxx-commits mailing list