[libcxx-commits] [PATCH] D115579: [libc++] Make ThrowingIterator constexpr

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added inline comments.


================
Comment at: libcxx/test/support/test_iterators.h:538
 
-    friend bool operator!=(const ThrowingIterator& a, const ThrowingIterator& b) {
+    TEST_CONSTEXPR_CXX14 friend bool operator!=(const ThrowingIterator& a, const ThrowingIterator& b) {
         return !(a == b);
----------------
Nit: Here, and I'm guessing on the ctors, I'd prefer to see `TEST_CONSTEXPR` instead of `TEST_CONSTEXPR_CXX14`: i.e., pick the most aggressive constexprness possible. (Applies to any single-statement const-qualified member function.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115579/new/

https://reviews.llvm.org/D115579