[libcxx-commits] [PATCH] D113253: [runtimes] Fix building initial libunwind+libcxxabi+libcxx with compiler implied -lunwind

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

In D113253#3181934 <https://reviews.llvm.org/D113253#3181934>, @pdhaliwal wrote:

> Hi, this is again causing issues on amdgpu buildbot (https://lab.llvm.org/buildbot/#/builders/193). In the logs, I see that cmake was unable to find libelf dependency which is necessary for openmp plugins to be built and tested. In absence of libelf, the bot, currently, silently ignores and run non-amdgpu tests. I locally reverted this patch and found that tests are again working fine.

Sorry about that - I reverted this now again.

I think the best way forward with this is to just skip the changes to `project()`/`enable_languages` (as setting `CMAKE_TRY_COMPILE_TARGET_TYPE=STATIC_LIBRARY` affects what the compiler can detect when the setup is a full working toolchain), and just require callers to set `CMAKE_{C,CXX}_COMPILER_WORKS=YES` when building with an incomplete toolchain. I'll update the patch in that form, and reapply again after CI completes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113253/new/

https://reviews.llvm.org/D113253