[libcxx-commits] [PATCH] D112012: [benchmarks] Move libcxx's fork of google/benchmark and llvm/utils' under third-party

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

This broke building for MinGW, due to a local change (from rG948ce4e6edec6ad3cdf1911fc3e8e9569140d4ff <https://reviews.llvm.org/rG948ce4e6edec6ad3cdf1911fc3e8e9569140d4ff> that never was upstreamed) that was dropped as part of the move. I've submitted that fix upstream now in https://github.com/google/benchmark/pull/1302, and I filed D115434 <https://reviews.llvm.org/D115434> to get it applied on the new location.

This also showed another brittleness in the benchmark library, as it's built with `-Werror` by default (in non-MSVC builds). As the benchmark library is built by default when building all of LLVM, building it with `-Werror` feels excessive and brittle. `-Werror` was commented out in the original import of the benchmark library in rG0addd170ab0880941fa4089c2717f3f3a0e4e25a <https://reviews.llvm.org/rG0addd170ab0880941fa4089c2717f3f3a0e4e25a>, but wasn't commented out in the copy in libcxx (which wasn't built by default, at least not as widely, and thus the issue wasn't noticed there).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112012/new/

https://reviews.llvm.org/D112012