[libcxx-commits] [PATCH] D115315: [libc++][ranges] Implement ranges::uninitialized_default_construct{, _n}.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/test/std/utilities/memory/specialized.algorithms/uninitialized.construct.default/ranges_uninitialized_default_construct_n.pass.cpp:27
+
+namespace ranges = std::ranges;
+
----------------
I forgot to mention, I'm not a big fan of this alias (I'd rather see `std::ranges::` everywhere), but if you //must// pick a name for the alias, then this is 100% the best name. It prevents me from `git grep -l std::ranges::foo`, but at least I can still `git grep -l ranges::foo` if I suspect this trick has been played. :)


================
Comment at: libcxx/test/std/utilities/memory/specialized.algorithms/uninitialized.construct.default/ranges_uninitialized_default_construct_n.pass.cpp:3
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
----------------
var-const wrote:
> I think it would make sense to merge this file with the version taking iterator+sentinel / range because the tests are very similar and it would help cut down the boilerplate.
FWIW, that seems like a reasonable rationale to me, but it //does// go against our general rule of "separate test files for separate functionalities." And the boilerplate isn't costing us much.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115315/new/

https://reviews.llvm.org/D115315