[libcxx-commits] [PATCH] D114920: [libc++] Explicitly reject `uniform_int_distribution<bool>`.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added subscribers: phosek, thakis, rnk.
ldionne added a comment.

Okay, so I have some initial results of my investigation. I found some uses of `uniform_int_distribution` with things like `uint8_t`, `char`, and `unsigned char`. There was definitely some breakage, however nothing that seemed entirely unmanageable.

I say we go for it, but we definitely need to add a release note. Also, we'll want to sync up with some folks that build their code bases from libc++ trunk (like I think @thakis @rnk @phosek) or they might encounter issues. They should proof their code bases before we land this (or if that can't be done in a reasonable time frame, then they can revert this commit internally).

One thing we could do to make things easier would be to have the `static_assert`s in a different commit, that way folks could just revert that one locally until they have solved their problems.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114920/new/

https://reviews.llvm.org/D114920