[libcxx-commits] [PATCH] D115275: [libc++] Remove _LIBCPP_DEFAULT

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/include/__config:840-844
-#ifdef _LIBCPP_CXX03_LANG
-#  define _LIBCPP_DEFAULT {}
-#else
-#  define _LIBCPP_DEFAULT = default;
-#endif
----------------
Quuxplusone wrote:
> I have looked at this in the past and decided not to mess with it, because it changes our ABI in C++03 mode. @ldionne, could you take another look with ABI in mind and just confirm whether this still LGTY?
> 
> Remember `=default`ed members can be trivial, but `{}`'ed members are never trivial, for purposes of ABI.
Isn't `_LIBCPP_HIDE_FROM_ABI` supposed to mitiagte that problem?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115275/new/

https://reviews.llvm.org/D115275