[libcxx-commits] [PATCH] D70631: Microsoft's floating-point to_chars powered by Ryu and Ryu Printf

Mon Dec 6 18:50:40 PST 2021

ldionne added a comment.

In D70631#3175290 <https://reviews.llvm.org/D70631#3175290>, @phosek wrote:

> In D70631#3174380 <https://reviews.llvm.org/D70631#3174380>, @phosek wrote:
>
>> This broke all our builders that use the bootstrapping build due to PR52584 <https://llvm.org/PR52584>. I saw you disabled the use of debugging information for libc++ ci in 15495be014032339600cda7770d7bf45dfb10d54 <https://reviews.llvm.org/rG15495be014032339600cda7770d7bf45dfb10d54>, but there are other projects that build LLVM from source at HEAD which will be affected by that issue. I'd prefer if this change was reverted until PR52584 <https://llvm.org/PR52584> is addressed or we find some other workaround.
>
> @ldionne Would it be fine with you if I revert this change? I haven't heard back from @Mordante and libc++ build is still failing all our builders because of Clang ICE that hasn't yet been addressed. We cannot disable the use of debug info because we use it for symbolization, and we don't want to disable assertions because we might then miss other issues.

Yes, please revert the change. We will investigate tomorrow. I think @Mordante is in a different time zone.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70631/new/

https://reviews.llvm.org/D70631